Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toString(uint8_t) with template to avoid unintentional truncation of values #2229

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Replace toString(uint8_t) with template to avoid unintentional truncation of values #2229

merged 1 commit into from
Feb 25, 2021

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Feb 23, 2021

e.g. uint32_t -> uint8_t gets truncated without warning

@slaff slaff added this to the 4.3.0 milestone Feb 24, 2021
@slaff
Copy link
Contributor

slaff commented Feb 24, 2021

Please, check the failing CI tests.

@mikee47
Replace toString(uint8_t) with template to avoid unintentional trun…
a4c6e8e 
…cation of values

e.g. uint32_t -> uint8_t gets truncated without warning
@slaff slaff merged commit 90908fe into SmingHub:develop Feb 25, 2021
@slaff slaff mentioned this pull request Feb 26, 2021
Closed
5 tasks
@mikee47 mikee47 deleted the fix/toString(uint8_t) branch February 26, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff